-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GRPH-75] node restore improvments #101
Conversation
…ional blocks in block_database Fixed tests wrt db.open
Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. i tested it and seems to be working as expected.
Peerplays don't have the --plugin
option for its witness_node. To remove bookie one actually have to remove the line where the plugin is enabled in programs/witness/main.cpp
. This is inconvenient and i am pretty sure this option will be added. This is not in the scope of this pull request.
Good work.
Backport of the Bitshares bitshares/bitshares-core#339